Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create story-issue.md #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create story-issue.md #492

wants to merge 1 commit into from

Conversation

chizo-gov
Copy link

@chizo-gov chizo-gov commented Sep 12, 2024 •
edited
Loading

Changes proposed in this pull request:

Related issues

Submitter checklist

  • Added logging is not capturing sensitive data and is set to an appropriate level (DEBUG vs INFO etc)
  • Updated relevant documentation (README, ADRs, explainers, diagrams)

Security considerations

  • None

@chizo-gov
Create story-issue.md
9398809 
Signed-off-by: chizo-gov <[email protected]>
@chizo-gov chizo-gov requested a review from a team as a code owner September 12, 2024 20:14
cannandev
cannandev approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@cannandev cannandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this happen!

cannandev
cannandev suggested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@cannandev cannandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to remove the line...

[Note the any security considerations here, or make note of why there are none]

...so the build can pass. Currently, the build is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannandev cannandev Awaiting requested review from cannandev

@hursey013 hursey013 Awaiting requested review from hursey013

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chizo-gov @cannandev