Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update log_type field to be ignored if value is nil #15

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

markdboyd
Copy link

Changes proposed in this pull request:

  • update log_type field to be ignored if value is nil

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just changing logic for detecting and setting a log_type property for incoming logs

@markdboyd markdboyd requested a review from a team as a code owner December 20, 2024 21:13
Copy link

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markdboyd markdboyd merged commit f77074b into main Dec 20, 2024
1 check passed
@markdboyd markdboyd deleted the update-log-type-field branch December 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants