Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly keep previous default for s3 transition lifecycle property #1828

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

AWS changed the default for this property from varies_by_storage_class to all_storage_classes_128K. For now we are setting this field explicitly so we keep the old behavior.

security considerations

None.

@jameshochadel jameshochadel requested a review from a team as a code owner February 10, 2025 20:28
AWS changed the default for this property from varies_by_storage_class to all_storage_classes_128K. For now we are setting this field explicitly so we keep the old behavior.

- The AWS provider has an issue describing this change here: hashicorp/terraform-provider-aws#41126
- AWS docs here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-lifecycleconfiguration.html
- Slack thread discussing the change here: https://gsa-tts.slack.com/archives/C0ENP71UG/p1739218411084849
@jameshochadel jameshochadel force-pushed the s3-transition-lifecycle-default branch from 3549d7c to efc8074 Compare February 10, 2025 20:29
@jameshochadel jameshochadel merged commit 468056e into main Feb 10, 2025
2 checks passed
@jameshochadel jameshochadel deleted the s3-transition-lifecycle-default branch February 10, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants