Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline to use hardened images #79

Merged
merged 2 commits into from
Jun 27, 2024
Merged

update pipeline to use hardened images #79

merged 2 commits into from
Jun 27, 2024

Conversation

dandersonsw
Copy link
Contributor

@dandersonsw dandersonsw commented Jun 27, 2024

Changes proposed in this pull request:

  • Update pipeline to use hardened general-task image
  • Update pipeline to use hardened github-pr-resource image

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Update to use hardened images

@dandersonsw dandersonsw requested a review from a team as a code owner June 27, 2024 19:21
markdboyd
markdboyd previously approved these changes Jun 27, 2024
@dandersonsw
Copy link
Contributor Author

@markdboyd mind approving again? Had to fix a resource type that I missed

@dandersonsw dandersonsw merged commit d2a782f into main Jun 27, 2024
2 checks passed
@dandersonsw dandersonsw deleted the update-pipeline branch June 27, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants