Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline for newer register service broker #81

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Oct 23, 2024

Changes proposed in this pull request:

  • Switch to using the newer style pipeline-tasks/register-service-broker-and-set-plan-visibility.yml, Concourse didn't seem to want to follow the symlink introduced with cloud-gov/pipeline-tasks@648a1f7
  • With this also needed to replace the reference to SERVICE_ORGANIZATION_BLACKLIST with SERVICE_ORGANIZATION_DENYLIST as the older variable has been deprecated
  • Part of "make them all green" pipeline maintenance: https://github.com/cloud-gov/private/issues/618

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Returns functionality to what we had before, should not have any changes to our security footprint

@cweibel cweibel requested a review from a team as a code owner October 23, 2024 19:29
@cweibel cweibel requested a review from a team October 23, 2024 19:33
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Chris, i like denylist wording better also

@cweibel cweibel merged commit 7d827ea into main Oct 23, 2024
2 checks passed
@cweibel cweibel deleted the register-service-broker-and-set-plan-visibility branch October 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants