-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some log noise #195
base: master
Are you sure you want to change the base?
fix some log noise #195
Conversation
This otherwise becomes too noisy when used in another library.
This is too noisy when used as a library, and gets logged once per thread even.
It make sense, perhaps we can provide these info by other method? |
You mean, you'd be fine to merge this in case there's ways to get out If so, any preferences on the API?
... and stored in
|
Hmmh, passing these flags up requires touching a lot of things. No code is arguably having a use for these values (otherwise it would have been exposed already), and the only usecase would seems to be logging it to the user (when they're /debugging/ The current situation causes every user of the library to get these log statements printed out to their CLI users, even if everything is fine. At least if the binary doesn't do some extra work on explicitly filtering out info log messages for the Another example: A HTTP client library also doesn't print the source port it uses for the outgoing TCP connection whenever it opens one, at least not in the info/default log level. If users want (and use it in a log framework that allows crate-level log levels), they can crank up the debug level on that specific crate. |
Poke :-) Any chance we can land this? |
This downgrades two of the
info!
level log messages todebug
.They becomes quite noisy if
fuse-backend-rs
is used as a library. Logging it atdebug!
keeps them silent until log levels are increased.