Skip to content

Conversation

rakeshclouddevops
Copy link
Contributor

what

  • added the parameter for used the hard coded secrets.

why

  • it is required to be latest.

references

  • Link to any supporting jira issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a Jira issue #123

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM Broker does not have audit logging enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:230
────────────────────────────────────────────────────────────────────────────────
  204    resource "aws_mq_broker" "default" {
  ...  
  230  [     audit   = var.audit_log_enabled ? true : false (false)
  ...  
  278    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-mq-enable-audit-logging
      Impact Without audit logging it is difficult to trace activity in the MQ broker
  Resolution Enable audit logging

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/mq/enable-audit-logging/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/mq_broker#audit
────────────────────────────────────────────────────────────────────────────────


Result #2 LOW Log group is not encrypted. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:196-201
────────────────────────────────────────────────────────────────────────────────
  196    resource "aws_cloudwatch_log_group" "mq_logs" {
  197      count             = var.enable_cloudwatch_logs ? 1 : 0
  198      name              = "/aws/mq/${var.mq_broker_name}"
  199      retention_in_days = var.cloudwatch_log_retention_days
  200      tags              = var.tags
  201    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-cloudwatch-log-group-customer-key
      Impact Log data may be leaked if the logs are compromised. No auditing of who have viewed the logs.
  Resolution Enable CMK encryption of CloudWatch Log Groups

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/cloudwatch/log-group-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group#kms_key_id
────────────────────────────────────────────────────────────────────────────────


Result #3 LOW Broker does not have general logging enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:229
────────────────────────────────────────────────────────────────────────────────
  204    resource "aws_mq_broker" "default" {
  ...  
  229  [     general = var.general_log_enabled ? true : false (false)
  ...  
  278    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-mq-enable-general-logging
      Impact Without logging it is difficult to trace issues
  Resolution Enable general logging

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/mq/enable-general-logging/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/mq_broker#general
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             93.543µs
  parsing              111.83324ms
  adaptation           120.936µs
  checks               3.317639ms
  total                115.365358ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     86
  files read           4

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  2

  1 passed, 3 potential problem(s) detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants