gRPC API surface plus response/requests datatype naming conventions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import grpc | ||
| from ft.proto import fine_tuning_studio_pb2_grpc | ||
| from ft.service import FineTuningStudioApp | ||
| from multiprocessing import Process |
There was a problem hiding this comment.
What multiprocessing are we planning to implement?
There was a problem hiding this comment.
This was an old artifact from trying different ways of spawning the gRPC server. Originally I was trying to spawn the gRPC server as a sub-process to the Streamlit server, but this was causing some headache because streamlit reruns entry point scripts upon every interaction.
We can probably safely remove this in the future.
jasonmeverett
pushed a commit
that referenced
this pull request
Nov 1, 2024
Added dataset bug fix. Where data will be taken of 1st adapter only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC API Surface
This PR introduces a gRPC servicer class that can be used to implement the application logic API. This is currently implemented in
ft/app.py, where the API will remain until we finalize implementing the gRPC layer (in a future PR).