Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload#3830
Closed
athithyaaselvam wants to merge 1 commit intomasterfrom
Closed
Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload#3830athithyaaselvam wants to merge 1 commit intomasterfrom
athithyaaselvam wants to merge 1 commit intomasterfrom
Conversation
… for document upload Change-Id: Iab7b73cfcefd42348a37a38d9bafb9964bf551d4
athithyaaselvam
requested review from
Harshg999,
agl29,
amitsrivastava,
ranade1,
tabraiz12 and
wing2fly
Collaborator
|
Why are we adding a dedicated middleware only for this specific use-case? Can't we do this closer to the core document import code section? |
|
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload. When the
chunked_file_uploaderandtask_serverconfig is enabled, the document uploads tries to useFineUploaderChunkedUploadHandler. Since user's don't upload large files in document upload's page (small json files with saved queries are uploaded), the chunked_file_upload implementation isn't needed. So adding a middleware to switch the upload handler in Documents upload page toHDFSfileUploadHandlereven when the HDFS, S3, Azure FS might use theFineUploaderChunkedUploadHandler.How was this patch tested?
Tested on mac, docker based system. Tested uploading a document concurrently during HDFS, S3, Azure file uploads.
Please review Hue Contributing Guide before opening a pull request.