fix: preserve HTTP response body after retries#1272
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yash Khare <khareyash05@gmail.com>
officialasishkumar
force-pushed
the
1238-preserve-http-response-body-on-retry
branch
from
97aaa59 to
85a35eb
Compare
Member
|
@officialasishkumar needs rebase and signed-off commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1238
Summary
RetriesResult.Unwrap()so wrapped HTTP results remain discoverable through standard error traversal*http.ResultSend()test that checks the final response body is preservedTesting
go test ./protocol/http