Skip to content

Conversation

@whoiskatrin
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025

⚠️ No Changeset found

Latest commit: 8e9b4e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@claude
Copy link

claude bot commented Nov 4, 2025

Claude Code Review

Summary: Changes look good overall. The workflow updates improve clarity and structure.

Issues identified:

  1. Tool restriction may be too limiting (line 195): --allowed-tools Bash,Edit restricts Claude to only Bash and Edit tools. This could prevent:

    • Reading files with the Read tool (needed to understand existing cloudflare-docs structure)
    • Using Glob/Grep for finding relevant documentation files
    • Using Write tool for creating new documentation files

    Consider using --allowed-tools Bash,Edit,Read,Write,Glob,Grep or removing the restriction entirely to allow the workflow to complete all 8 steps effectively.

  2. Minor: Multiline output in step 8 (lines 124-139): The embedded bash script in the prompt uses \n for newlines in COMMENT_BODY, which may not render correctly. Consider using $'\n' or a heredoc for proper newline handling in the actual execution.

What's working well:

  • Added proper GitHub permissions (lines 10-13)
  • Better prompt structure with explicit 8-step workflow
  • Improved documentation guidelines (Diátaxis framework)
  • Proper use of GITHUB_OUTPUT for passing multiline prompt
  • Tool restriction adds security boundaries

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/agents@633

commit: 8e9b4e8

@threepointone
Copy link
Contributor

📚 Documentation sync PR created in cloudflare-docs: cloudflare/cloudflare-docs#26302

The new getAgentStatus() function has been documented in the API reference under Calling Agents - Monitoring Agent status.

@cloudflare cloudflare deleted a comment from threepointone Nov 5, 2025
@threepointone
Copy link
Contributor

📚 Documentation sync PR: cloudflare/cloudflare-docs#26302

This comment will be updated as the PR changes.

@whoiskatrin whoiskatrin changed the title add agent status monitoring function update docs syncing workflow Nov 5, 2025
@whoiskatrin whoiskatrin marked this pull request as ready for review November 5, 2025 14:00
@whoiskatrin whoiskatrin merged commit 9741e80 into main Nov 5, 2025
7 checks passed
@whoiskatrin whoiskatrin deleted the test-docs-sync-pr branch November 5, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants