fix: allow returning a non-streaming reponse from onChatMessage()
#761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ffbee0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iTrooz
force-pushed
the
respond_with_raw_string
branch
from
9fe6f2a to
6e83bfe
Compare
iTrooz
force-pushed
the
respond_with_raw_string
branch
from
6e83bfe to
1e8d4f7
Compare
iTrooz
changed the title
onChatMessage()onChatMessage()
commit: |
- Add _broadcastTextEvent helper with discriminated union for type safety - Inject text-start/text-end events for plain text responses per AI SDK v5 protocol - Add id field to text-delta events (was missing) - Move isSSE check outside the loop - Add tests verifying event sequence and id consistency
pull common code into a helper file
threepointone
approved these changes
Jan 8, 2026
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
moves some common stuff into modules
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
actually hold up I think I want to refactor a bit more, I'll land it when happy
Contributor
Author
|
I was planning to submit a second PR refactoring the file after this, but if you prefer to do it yourself, sure |
Contributor
|
let's land this and then work on the next one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, doing
from an AIChatAgent creates an error on the frontend, because doing so is only generating a
text-deltaevent, and not thetext-startandtext-endevents that should go in-between, according to https://ai-sdk.dev/docs/ai-sdk-ui/stream-protocol#text-start-part (from my understanding ?)This PR fixes it by adding these 2 events.