Skip to content

pipe SQL errors into the existing onError method using a new SqlError class #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whoiskatrin merged 5 commits into from
Jan 6, 2026
Merged

pipe SQL errors into the existing onError method using a new SqlError class #768

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b72e17
feat(agents): add onSqlError hook for customizable SQL error logging
whoiskatrin Jan 6, 2026
7619bc1
Create spotty-donkeys-compare.md
whoiskatrin Jan 6, 2026
d988b8e
refactor(agents): use SqlError class instead of onSqlError hook
whoiskatrin Jan 6, 2026
adcb1c2
fix(agents): pass cause to Error super() for proper error chain
whoiskatrin Jan 6, 2026
3d7670c
Update spotty-donkeys-compare.md
whoiskatrin Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-donkeys-compare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"agents": patch
---

add onSqlError hook for customizable SQL error logging
11 changes: 10 additions & 1 deletion packages/agents/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ export class Agent<
// Execute the SQL query with the provided values
return [...this.ctx.storage.sql.exec(query, ...values)] as T[];
} catch (e) {
console.error(`failed to execute sql query: ${query}`, e);
Copy link
Contributor

@threepointone threepointone Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead why don't we use our logger directly here?

Copy link
Contributor

@threepointone threepointone Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or pipe into onError

Copy link
Contributor Author

@whoiskatrin whoiskatrin Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with piping, done that

this.onSqlError(query, e);
throw this.onError(e);
}
}
Expand Down Expand Up @@ -871,6 +871,15 @@ export class Agent<
throw theError;
}

/**
* Handle SQL execution errors. Override this method to customize logging behavior.
* @param query The SQL query that failed
* @param error The error that occurred
*/
onSqlError(_query: string, _error: unknown): void {
console.error(`failed to execute sql query: ${_query}`, _error);
}

/**
* Render content (not implemented in base class)
*/
Expand Down
Loading