Don't return shutdown errors during shutdown #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jan 31, 2022
Contributor
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Is this something we can test somehow? When did you run into this error?
Collaborator
Author
In production with real-world websites. |
nox
force-pushed
the
shutdown
branch
3 times, most recently
from
85c2e8a to
439a549
Compare
nox
commented
Dec 6, 2022
boring/src/ssl/mod.rs
Outdated
| if let Some(stack) = e.ssl_error() { | ||
| if let Some(first) = stack.errors.first() { | ||
| if first.code() as i32 == boring_sys::SSL_R_PROTOCOL_IS_SHUTDOWN { | ||
| return Poll::Ready(Ok(ShutdownResult::Received)); |
Collaborator
Author
There was a problem hiding this comment.
Not exactly sure what this means. This is why I didn't put it in the boring crate at first.
nox
force-pushed
the
shutdown
branch
3 times, most recently
from
b46582e to
1d3fb25
Compare
Collaborator
|
I've rebased it and added a safe API for ERR_peek_last_error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.