Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change extension of assembler headers .h -> .s #540

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change extension of assembler headers .h -> .s #540

wants to merge 1 commit into from

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Mar 20, 2025

Related to #537

@armfazh armfazh mentioned this pull request Mar 20, 2025
Open
Lekensteyn
Lekensteyn approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new names sounds reasonable. These files only contain macros and no other actual code.

Minor suggestion: consider explaining in the commit message why it was renamed.

I just restarted the Go-1.22/arm64 build, it failed with an usual error that I cannot reproduce locally with the same Docker image.

@Lekensteyn Lekensteyn mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwesterb bwesterb bwesterb approved these changes

@Lekensteyn Lekensteyn Lekensteyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armfazh @bwesterb @Lekensteyn