Skip to content

Conversation

renandincer
Copy link
Member

Applies the change mentioned in #2 across the entire Stream documentation.

Copy link
Contributor

@Everlag Everlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM; one ask about documenting how to get an API token plus one phrasing nit

@@ -4,7 +4,7 @@ order: 3

# Direct creator uploads

Direct creator uploads allow users to upload videos without API keys. A common place to
Direct creator uploads allow users to upload videos without API tokens. A common place to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be more general; ie, 'without API credentials'

That way its generic across tokens and keys.

3. Your Cloudflare Account API Token

Alternatively, you can also use [bearer tokens](https://support.cloudflare.com/hc/en-us/articles/200167836-Managing-API-Tokens-and-Keys).
1. A Cloudflare Account API Token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting an API token is not easy

There's no preset for stream yet
image

So you have to go through this dialog
image

Which is very complicated.

We should either have at least one token preset or a dedicated docs page for 'Getting an API token'

Copy link
Contributor

@adamschwartz adamschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of Markdown formatting, it looks good.

@renandincer renandincer merged commit 0acec40 into cloudflare:master Oct 23, 2020
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b38768
Status: ✅  Deploy successful!
Preview URL: https://13e7739c.cloudflare-docs-7ou.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:stream Related to Stream product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants