Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {cache: no-cache} to Workers cache #19158

Draft
wants to merge 2 commits into
base: production
Choose a base branch
from
Draft

Add {cache: no-cache} to Workers cache #19158

wants to merge 2 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 13, 2025 •
edited
Loading

Summary

Add a missing cache supported value

Ref:

@tewaro is this ok?

/cc @ToriLindsay

Documentation checklist

@github-actions github-actions bot added the product:workers Related to Workers product label Jan 13, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025 •
edited
Loading

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c5b03e0
Status: ✅  Deploy successful!
Preview URL: https://90e36781.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://vb-branch-1.cloudflare-docs-7ou.pages.dev

View logs

@github-actions GitHub Actions
Copy link

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/workers/examples/cache-using-fetch/ https://vb-branch-1.cloudflare-docs-7ou.pages.dev/workers/examples/cache-using-fetch/

@tewaro
Copy link
Contributor

tewaro commented Jan 13, 2025

The feature is still experimental. We do not support it yet because the necessary changes in pingora are not there. They are scheduled to happen soon. But until then what we have is just a sketch of the interface and will not work as expected.

tewaro
tewaro requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tewaro tewaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be delayed until we officially have a compat date for the no-cache changes.

@vicb vicb marked this pull request as draft January 13, 2025 17:24
@vicb
Copy link
Contributor Author

vicb commented Jan 13, 2025

Thanks for the review/feedback @tewaro.
I didn't pay attention that you only modified the experimental types on the PR.
Marking the PR as draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewaro tewaro tewaro requested changes

@ToriLindsay ToriLindsay ToriLindsay approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@ToriLindsay ToriLindsay

Labels
product:workers Related to Workers product size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vicb @tewaro @ToriLindsay @irvinebroque @mikenomitch @GregBrimble @WalshyDev