Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOIP] Call out no expected downtime when setting up address maps #19448

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

RebeccaTamachiro
Copy link
Contributor

Summary

PCX-14819

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner January 27, 2025 14:32
Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 299c692
Status: ✅  Deploy successful!
Preview URL: https://ca6d1a33.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://rebecca-byoip-address-maps-n.cloudflare-docs-7ou.pages.dev

View logs

@github-actions github-actions bot added product:byoip Related to BYOIP size/xs labels Jan 27, 2025
@@ -10,6 +10,10 @@ import { GlossaryTooltip } from "~/components";

Consider the sections below to learn how to set up address maps.

:::note
There is **no expected downtime** when setting up or updating your address maps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I wouldn't use any particular formatting for "no expected downtime" (we usually reserve bold for UI labels). If there was expected downtime, this would be a warning and eventually we could need the bold.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I usually avoid the bold but was afraid the no could go unnoticed in the middle of this sentence. Will revisit with more time later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PCX-15574

@RebeccaTamachiro RebeccaTamachiro merged commit 4c9c080 into production Jan 28, 2025
13 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/byoip-address-maps-no-downtime branch January 28, 2025 10:47
deadlypants1973 pushed a commit that referenced this pull request Jan 29, 2025
…19448)

* Add note about no downtime expected to setup.mdx

* Update links from index to land at top of the setup page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:byoip Related to BYOIP size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants