Fix killProcess not terminating child processes #27520
Open
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation to reflect that killProcess() now properly terminates the entire process tree including child processes, preventing orphaned processes from continuing to run after the parent is killed. Changes: - Update killProcess() API reference to clarify it kills process groups - Add example showing child process termination behavior - Update background processes guide with detailed explanation - Add example demonstrating process tree cleanup Syncs documentation with cloudflare/sandbox-sdk#339
agents-git-bot
bot
requested review from
a team,
ghostwriternr and
whoiskatrin
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update documentation to reflect the fix in cloudflare/sandbox-sdk#339 where
killProcess()now properly terminates child processes.Previously,
killProcess()only terminated the parent shell process, leaving child processes running as orphans. The fix ensures that killing a background process now terminates the entire process tree by using process groups.Changes
Commands API reference (
/sandbox/api/commands.mdx):killProcess()description to clarify it terminates the entire process groupBackground processes guide (
/sandbox/guides/background-processes.mdx):Documentation sync
This PR syncs documentation with the bug fix in cloudflare/sandbox-sdk#339.
🤖 Generated with Claude Code