Fix preview URL parsing for sandbox IDs with hyphens #27611
+106
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agents-git-bot
bot
requested review from
a team,
ghostwriternr and
whoiskatrin
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
agents-git-bot
bot
force-pushed
the
sync-docs-pr-352
branch
from
7b53869 to
a517499
Compare
agents-git-bot
bot
changed the title
- Add custom token support for exposePort() API - Document breaking change: tokens no longer support hyphens - Update URL format throughout docs to include tokens - Add examples for stable URLs with custom tokens Reflects changes from cloudflare/sandbox-sdk PR 352
agents-git-bot
bot
force-pushed
the
sync-docs-pr-352
branch
from
a517499 to
21ea47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Sandbox documentation to reflect changes from cloudflare/sandbox-sdk PR #352:
What Changed
{port}-{sandbox-id}-{token}.domain.comDocumentation Updates
/sandbox/api/ports/) to document the newtokenparameter and custom token requirements/sandbox/concepts/preview-urls/) to explain token types and the new URL format with examples/sandbox/guides/expose-services/) to include stable URL patterns and custom token best practicesBreaking Change Impact
Existing preview URLs with hyphenated custom tokens will fail until ports are re-exposed with valid tokens (no hyphens). This change fixes preview URL parsing for sandbox IDs containing hyphens (UUIDs).
Source: cloudflare/sandbox-sdk#352