Add support for API Shield client certificates endpoints#1686
Closed
arkadiuss wants to merge 5 commits intocloudflare:masterfrom
Closed
Add support for API Shield client certificates endpoints#1686arkadiuss wants to merge 5 commits intocloudflare:masterfrom
arkadiuss wants to merge 5 commits intocloudflare:masterfrom
Conversation
|
changelog detected ✅ |
Contributor
|
thanks for the effort with the PR here! unfortunately, v2 is pretty close to being released and it looks like all of these endpoints are already covered so we won't be adding them to the legacy SDK. if you want to use this now, you can checkout v2.0.0 Beta and use that instead. there will be work later this week in the Terraform provider supporting mux'ing the two versions alongside each other. |
Author
|
great, thank you for the information, I totally understand that. I will wait till it will be available in the Terraform provider. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I would like to add support for "API Shield client certificates for a zone" endpoints (docs) because the functionality is missing in the current version and would be useful especially in the Terraform provider. I did my best to follow practices from other places.
Description
I found an issue created some time ago here. Changes include implementation of the following endpoints:
Has your change been tested?
Unit tests and running the new functions locally on my account.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.