Add WaitingRoom.CookieAttributes property#3388
Merged
jacobbednarz merged 3 commits intocloudflare:masterfrom Oct 16, 2024
Merged
Add WaitingRoom.CookieAttributes property#3388jacobbednarz merged 3 commits intocloudflare:masterfrom
jacobbednarz merged 3 commits intocloudflare:masterfrom
Conversation
|
This functionality has been released in v0.108.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the
WaitingRoom.CookieAttributesproperty.Note that this property is mentioned in the API docs and in some guidelines (eg Waiting Room / Additional options / Embed in an iFrame, but is not available via dash.cloudflare.com (which is mentioned in the iFrame guide).
This property is also supported in the Python and Typescript SDKs.
Has your change been tested?
I've tested this locally by setting this property do non-default values in the input for the
CreateWaitingRoom()andUpdateWaitingRoom()calls, and then observing thatListWaitingRooms()returns the correct values.I haven't added automated tests, because there is no logic change. All a unit test would prove is that the name of the property can be copy-pasted from the Go tag into a unittest.
Types of changes
Checklist:
and relies on stable APIs.