Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script upload response placement field changes #3825

Conversation

danielrs
Copy link

Description

Adds the placement.mode field to the script upload response as an alternative to the now deprecated placement_mode.

Has your change been tested?

  • Yes, with unit tests.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation (DONE).
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Add the `placement` object to script responses in addition to
the now deprecated `placement_mode`.
Copy link

github-actions bot commented Jan 13, 2025

changelog detected ✅

@danielrs danielrs force-pushed the drivas/script-upload-placement-field-changes branch from 41538b5 to 9653794 Compare January 13, 2025 17:14
.changelog/3825.txt Outdated Show resolved Hide resolved
.changelog/3825.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit ed69723 into cloudflare:master Jan 15, 2025
7 checks passed
@github-actions github-actions bot added this to the v0.114.0 milestone Jan 15, 2025
Copy link

This functionality has been released in v0.114.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
@danielrs danielrs deleted the drivas/script-upload-placement-field-changes branch January 15, 2025 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants