Add Configuration for Monitoring via Prometheus Operator #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhthomas
reviewed
Aug 22, 2023
| failureThreshold: 1 | ||
| initialDelaySeconds: 10 | ||
| periodSeconds: 10 | ||
| ports: | ||
| - containerPort: {{ .Values.metrics.port }} | ||
| name: metrics |
There was a problem hiding this comment.
Suggested change
| name: metrics | |
| name: http-metrics |
uhthomas
reviewed
Aug 22, 2023
| ports: | ||
| - containerPort: {{ .Values.metrics.port }} | ||
| name: metrics | ||
| protocol: TCP |
There was a problem hiding this comment.
Redundant, the default is TCP.
Suggested change
| protocol: TCP |
|
Is there any reason to use a service monitor rather than a pod monitor? |
Updated to use a PodMonitor instead. I have no strong opinion on which to use. ServiceMonitors seem more ubiquitous, but there is no need to manage a service for just this use case. |
josephschadlick
changed the title
|
I do prefer the service approach because of scaling and routing. |
|
Please add also Grafana Dashboard ConfigMap |
|
any updates on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #11 was created and subsequently closed due to a lack of sufficient metrics exposed in cloudflared.
Now that cloudflared supports a more useful set of metrics (described here), I would like to once again propose enabling configuration for metrics collection via a servicemonitor resource in both the cloudflare-tunnel and cloudflare-tunnel-remote charts.