docs: fix CDP endpoint authentication documentation#134
Open
yavzius wants to merge 1 commit intocloudflare:mainfrom
Open
docs: fix CDP endpoint authentication documentation#134yavzius wants to merge 1 commit intocloudflare:mainfrom
yavzius wants to merge 1 commit intocloudflare:mainfrom
Conversation
The documentation incorrectly stated that CDP_SECRET is passed as a
header. The actual implementation uses a query parameter (?secret=<value>),
as shown in src/routes/cdp.ts and the bundled skill scripts.
Also corrects the WebSocket endpoint path from /cdp/devtools/browser/{id}
to the actual /cdp path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CDP documentation contains two inaccuracies:
CDP_SECRETheader, but the implementation uses a query parameterWS /cdp/devtools/browser/{id}but the actual endpoint isWS /cdpEvidence
Actual implementation (
src/routes/cdp.ts:155-157):Code comments confirm (
src/routes/cdp.ts:11):Bundled scripts use query params (
skills/cloudflare-browser/scripts/cdp-client.js:25):Changes
/cdp/devtools/browser/{id}to/cdp