Skip to content

Conversation

stepancheg
Copy link
Contributor

On macos, the error is

Error { etype: InternalError, esource: Unset, retry: Decided(false), cause: Some(Error { etype: BindError, esource: Unset, retry: Decided(false), cause: Some(Os { code: 49, kind: AddrNotAvailable, message: "Can't assign requested address" }), context: Some(Owned("Fail to connect to 240.0.0.1:80")) }), context: Some(Owned("Fail to connect to addr: 240.0.0.1:80, scheme: HTTP,")) }

Copy link
Contributor

@drcaramelsyrup drcaramelsyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, left a minor comment nit.

assert!(
error.etype() == &ConnectError
|| error.etype() == &ConnectTimedout
|| (error.etype() == &InternalError),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a comment explaining why we have the InternalError check here (i.e. "the error seen on mac is...")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

I added link to this PR, full error text might be too long to be included in code comments.

@stepancheg stepancheg force-pushed the test-conn-error-other branch from 9ac739a to 22c4141 Compare August 16, 2025 11:24
@stepancheg stepancheg force-pushed the test-conn-error-other branch from 22c4141 to 5b555f5 Compare August 16, 2025 11:24
@drcaramelsyrup drcaramelsyrup self-assigned this Aug 22, 2025
@drcaramelsyrup drcaramelsyrup added the bug Something isn't working label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants