Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreMatchingElsewhere option to promql/series #1298

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add ignoreMatchingElsewhere option to promql/series #1298

merged 1 commit into from
Feb 20, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.70.0-97-g4904e78
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Feb 19, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   34.79m ± 2%   34.87m ± 6%       ~ (p=0.436 n=10)
CheckRules-4     8.471 ± 2%    8.476 ± 2%       ~ (p=0.912 n=10)
geomean         542.9m        543.6m       +0.14%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.631 n=10)
CheckRules-4    986.5Mi ± 0%   985.5Mi ± 0%       ~ (p=0.123 n=10)
geomean         164.4Mi        164.3Mi       -0.05%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.516 n=10)
CheckRules-4    14.34M ± 0%   14.34M ± 0%       ~ (p=0.247 n=10)
geomean         1.375M        1.374M       -0.02%

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (bdce0a1) to head (4904e78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   95.28%   95.29%           
=======================================
  Files         106      106           
  Lines       13060    13087   +27     
=======================================
+ Hits        12444    12471   +27     
  Misses        468      468           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive force-pushed the series branch 2 times, most recently from fa30c2b to ed9616f Compare February 20, 2025 09:48
@prymitive prymitive changed the title WIP Add ignoreMatchingElsewhere option to promql/series Feb 20, 2025
@prymitive prymitive merged commit e045a3e into main Feb 20, 2025
20 checks passed
@prymitive prymitive deleted the series branch February 20, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants