Skip to content

Commit

Permalink
nginx: remove patch as QUIC is supported upstream since NGINX v1.25.0
Browse files Browse the repository at this point in the history
Closes #504, #687, #981, #1262, #1335, #1596.
  • Loading branch information
dzdidi authored Jan 10, 2025
1 parent 79c366d commit e434e42
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5,539 deletions.
42 changes: 0 additions & 42 deletions .github/workflows/stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,48 +228,6 @@ jobs:
- name: Run cargo clippy
run: cargo clippy --manifest-path=tools/http3_test/Cargo.toml -- -D warnings

nginx:
runs-on: ubuntu-latest
strategy:
matrix:
version: ["1.16.1"]
# Only run on "pull_request" event for external PRs. This is to avoid
# duplicate builds for PRs created from internal branches.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
steps:
- name: Checkout sources
uses: actions/checkout@v4
with:
submodules: 'recursive'

- name: Install stable toolchain
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUSTTOOLCHAIN }}

- name: Install dependencies
run: sudo apt-get install libpcre3-dev zlib1g-dev

- name: Download NGINX sources
run: curl -O https://nginx.org/download/nginx-${{ matrix.version }}.tar.gz

- name: Extract NGINX sources
run: tar xzf nginx-${{ matrix.version }}.tar.gz

- name: Build NGINX
run: |
cd nginx-${{ matrix.version }} &&
patch -p01 < ../nginx/nginx-1.16.patch &&
./configure \
--with-http_ssl_module \
--with-http_v2_module \
--with-http_v3_module \
--with-openssl="${{ github.workspace }}/quiche/deps/boringssl" \
--with-quiche="${{ github.workspace }}" \
--with-debug &&
make -j`nproc` &&
objs/nginx -V
docker:
runs-on: ubuntu-latest
# Only run on "pull_request" event for external PRs. This is to avoid
Expand Down
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ Android's DNS resolver uses quiche to [implement DNS over HTTP/3][android-http3]

quiche can be [integrated into curl][curl-http3] to provide support for HTTP/3.

### NGINX (unofficial)

quiche can be [integrated into NGINX](nginx/) using an unofficial patch to
provide support for HTTP/3.

[cloudflare-http3]: https://blog.cloudflare.com/http3-the-past-present-and-future/
[android-http3]: https://security.googleblog.com/2022/07/dns-over-http3-in-android.html
[curl-http3]: https://github.com/curl/curl/blob/master/docs/HTTP3.md#quiche-version
Expand Down
209 changes: 0 additions & 209 deletions nginx/README.md

This file was deleted.

Loading

0 comments on commit e434e42

Please sign in to comment.