fix: Propagate SIGTERM to child processes in killProcess #337
Conversation
Previously, killProcess would send SIGTERM to the subshell PID but the signal was not propagated to child processes. This caused the actual command to continue running as an orphan process while the API returned success. Added trap 'kill 0' TERM inside background subshells to forward SIGTERM to all processes in the process group when the subshell is killed.
🦋 Changeset detectedLatest commit: 2694b4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @pandemicsyn! Thanks for identifying this issue - The bug report is indeed accurate - However, trap 'kill 0' TERM seems to have a problem: in non-interactive bash (which we use), all processes share the same process group. kill 0 would terminate the entire session, not just the target command. I was able to validate this with an E2E test too. I've instead opened #339 with an alternative fix that uses bash job control ( To get this closed soon, I'm closing this PR in favour of #339 - thanks again for raising this! |
|
@ghostwriternr no worries , thanks for getting this squared away so quickly! |
2 participants
This fixes an issue where killProcess returns success but the actual process continues running.
When killProcess is called, it sends SIGTERM to the PID stored in the PID file. However, this PID is the subshell wrapper, not the actual command.
Added trap 'kill 0' TERM inside the background subshell. When the subshell receives SIGTERM, the trap fires and sends SIGTERM to all processes in the current process group (the subshell and its children).
fixes #338