mark actions.value optional to account for drop rules

cloudflare · Nov 23, 2023 · 8ca26a4 · 8ca26a4
1 parent cc801c3
commit 8ca26a4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changelog/2449.txt b/.changelog/2449.txt
@@ -1,3 +1,7 @@
 ```release-note:enhancement
 resource/cloudflare_email_routing_rule: add action type `drop`
 ```
+
+```release-note:enhancement
+resource/cloudflare_email_routing_rule: `action.value` is now optional to support `drop` rules not requiring it
+```
diff --git a/docs/resources/email_routing_rule.md b/docs/resources/email_routing_rule.md
@@ -55,7 +55,10 @@ resource "cloudflare_email_routing_rule" "main" {
 Required:
 
 - `type` (String) Type of supported action. Available values: `forward`, `worker`, `drop`.
-- `value` (List of String) An array with items in the following form.
+
+Optional:
+
+- `value` (List of String) An array with items in the following form. Only required when `type` is `forward` or `worker`.
 
 
 <a id="nestedblock--matcher"></a>

diff --git a/internal/sdkv2provider/schema_cloudflare_email_routing_rules.go b/internal/sdkv2provider/schema_cloudflare_email_routing_rules.go
@@ -76,9 +76,9 @@ func resourceCloudflareEmailRoutingRuleSchema() map[string]*schema.Schema {
 						ValidateFunc: validation.StringInSlice([]string{"forward", "worker", "drop"}, true),
 					},
 					"value": {
-						Description: "An array with items in the following form.",
+						Description: "An array with items in the following form. Only required when `type` is `forward` or `worker`.",
 						Type:        schema.TypeList,
-						Required:    true,
+						Optional:    true,
 						Elem: &schema.Schema{
 							Type:         schema.TypeString,
 							ValidateFunc: validation.StringLenBetween(0, 90),