Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/tunnel_virtual_network #2867

Merged
merged 9 commits into from
Oct 23, 2023
Merged

d/tunnel_virtual_network #2867

merged 9 commits into from
Oct 23, 2023

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Oct 21, 2023 •
edited by jacobbednarz
Loading

closes #2720

WIP, just need to run tests. Struggling with API permissions.

@danquack danquack changed the title create virtual network d/tunnel_virtual_network Oct 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023 •
edited
Loading

changelog detected ✅

jacobbednarz
jacobbednarz requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to #2866, a couple of nitpicks to resolve but solid effort. thanks!

danquack and others added 7 commits October 22, 2023 20:31
@danquack @jacobbednarz
Apply suggestions from code review
d61123e 
Co-authored-by: Jacob Bednarz <[email protected]>
@danquack
create datasource example
b83fd80
@danquack
update generated docs
7f2f4b2
@danquack
Merge branch 'master' of github.com:cloudflare/terraform-provider-clo…
d41aebd 
…udflare into 2720/virtual-network
@danquack
update account id
bb95137
@danquack
fix test ref
4dd5db9
@jacobbednarz
make test reliable
e20135c 
use an explicit depends_on to make sure the resource always exists before attempting to find it
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTunneVirtualNetwork_MatchName" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTunneVirtualNetwork_MatchName
--- PASS: TestAccCloudflareTunneVirtualNetwork_MatchName (10.32s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	11.032s

appreciate the PR @danquack 🙇

@danquack
Copy link
Contributor Author

@jacobbednarz appreciate you... are you using your user api key or token? I was struggling to find the proper permissions on my token auth

@jacobbednarz
Copy link
Member

both work for me. my API token is pretty broad though and will cover most permissions indiscriminately to avoid exactly that issue with the test suite 😛

@jacobbednarz jacobbednarz merged commit 498673e into cloudflare:master Oct 23, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.18.0 milestone Oct 23, 2023
github-actions bot pushed a commit that referenced this pull request Oct 23, 2023
Update CHANGELOG.md for #2867
75e1a87
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.18.0
Development

Successfully merging this pull request may close these issues.

New data sources for tunnel and virtual networks
2 participants
@danquack @jacobbednarz