Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add device posture rules data source #2868

Merged
merged 5 commits into from
Oct 23, 2023
Merged

add device posture rules data source #2868

merged 5 commits into from
Oct 23, 2023

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Oct 22, 2023

Adds a data source to return matching device posture rules.
Resolves #2864

@broswen broswen requested a review from jacobbednarz as a code owner October 22, 2023 19:06
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023 •
edited
Loading

changelog detected ✅

@broswen broswen force-pushed the bswenson/data-source-device-posture-rules branch from 6954df6 to 02927c7 Compare October 22, 2023 19:07
@jacobbednarz
Copy link
Member

lgtm once we finalise that failing test case 🥇

@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareDevicePostureRulesDataSource" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareDevicePostureRulesDataSource
--- PASS: TestAccCloudflareDevicePostureRulesDataSource (12.59s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	13.509s

@jacobbednarz jacobbednarz merged commit d498298 into cloudflare:master Oct 23, 2023
8 checks passed
@github-actions github-actions bot added this to the v4.18.0 milestone Oct 23, 2023
github-actions bot pushed a commit that referenced this pull request Oct 23, 2023
Update CHANGELOG.md for #2868
a4203a6
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.18.0
Development

Successfully merging this pull request may close these issues.

List device posture rules
2 participants
@broswen @jacobbednarz