Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_ruleset: Improve documentation #4752

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

zakcutner
Copy link
Contributor

  • Update links to the developer documentation.

  • Remove mention of Firewall Rules, which is deprecated.

  • Improve consistency of examples.

  • Add usage of ref field in examples.

* Update links to the developer documentation.

* Remove mention of Firewall Rules, which is deprecated.

* Improve consistency of examples.

* Add usage of `ref` field in examples.
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.


rules {
action = "execute"
ref = "execute_managed_ruleset"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these new ref example look great. this provides a more complete set of option. thanks!

@jacobbednarz jacobbednarz merged commit 41d1e16 into cloudflare:master Dec 11, 2024
7 of 8 checks passed
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 11, 2024
@zakcutner zakcutner deleted the rulesets branch December 11, 2024 19:10
Copy link
Contributor

This functionality has been released in v4.49.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants