Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLPROD-1439: Make terraform config consistent with the API on declaring optional fields for snippet rules #4787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FLPROD-1439: Make terraform config consistent with the API on declaring optional fields for snippet rules #4787

wants to merge 1 commit into from

Conversation

WowVeryLogin
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

changelog detected ✅

jacobbednarz
jacobbednarz reviewed Dec 18, 2024
View reviewed changes
internal/framework/service/snippet_rules/schema.go
Optional: true,
Optional: true,
PlanModifiers: []planmodifier.String{
defaults.DefaultString(""),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need an empty string here? or can it be totally optional?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions GitHub Actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WowVeryLogin @jacobbednarz