-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update matchit dependency #363
chore: update matchit dependency #363
Conversation
@@ -1,7 +1,7 @@ | |||
use std::{collections::HashMap, future::Future, rc::Rc}; | |||
|
|||
use futures_util::future::LocalBoxFuture; | |||
use matchit::{Match, Node}; | |||
use matchit::{Match, Router as Node}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node
has been renamed in https://github.com/ibraheemdev/matchit/releases/tag/v0.5.0
I had to perform this rename since Router
conflicts with the struct defined in line 45
Also, I am not sure how the release cycle works here, when can I expect to see v0.0.18 released? |
Would love to see getting this merged. any updates on this? v0.4.6 was released on Feb 1, 2022... |
@gytis-ivaskevicius the tests are failing though |
any plan to merge this? new version change the behavior of Catch-all Parameters
|
@hxzhao527 |
But matchit really needs to be updated, otherwise I see no hope in workers-rs. The dependency is too old already and it doesn't work as expected |
Done in #450 |
Updated matchit dependency. This PR resolves #362
Tested and it is working, ready to be merged