Make worker-build support custom JS shims
#686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebp
previously approved these changes
Dec 23, 2024
|
I think in the future we should explore different bundling modes, currently we always export a valid Worker but it seems like we may want a future where we export function/class stubs for people to do however they'd like and leave making a valid worker entirely up to them without them doing a custom shim. I'm fine with supporting this until then, but I think this is indicative of the holes in worker-build. |
mendess
requested changes
Jan 6, 2025
worker-build/src/main.rs
Outdated
Comment on lines
41
to
50
| let custom_shim = match env::var("CUSTOM_SHIM") { | ||
| Ok(path) => { | ||
| let path = Path::new(&path).to_owned(); | ||
|
|
||
| if !path.exists() { | ||
| None | ||
| } else { | ||
| println!("Using custom shim from {}", path.display()); | ||
| Some(path) | ||
| } | ||
| } | ||
| Err(_) => None, | ||
| }; | ||
|
|
||
| let shim_template = match custom_shim { | ||
| Some(path) => read_to_string(path)?, | ||
| None => SHIM_TEMPLATE.to_owned(), | ||
| }; | ||
|
|
There was a problem hiding this comment.
Could these two match statements be collapsed to avoid a TOCTOU bug?
There was a problem hiding this comment.
That's fair, i'll change it :)
This allows for users to provide their own JS shim and allowing them to customize behaviour: panic handling, wasm coredumps, and so on... It defaults to the embedded shim in the binary to avoid breaking changes,
LuisDuarte1
force-pushed
the
feature/worker-build-custom-shim
branch
from
bbbf9d9 to
0a31882
Compare
mendess
approved these changes
Jan 6, 2025
|
@zebp I'm going to merge this through CI because the error does not seem to be related at all with the proposed changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for users to provide their own JS shim and allowing them to customize behaviour: panic handling, wasm coredumps, and so on...
It defaults to the embedded shim in the binary to avoid breaking changes.