Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
RateLimiter
could not be retrieved withEnv::get_binding
, as described in #700.When trying to retrieve the rate limiter I was getting the following error:
From what I can tell, the underlying issue is that the runtime constructor name is actually
Ratelimit
, based on this code here:workers-rs/worker/src/env.rs
Line 123 in 38af58a
I was able to fix this by updating the type name from
RateLimiter
toRatelimit
in theEnvBinding
impl.If there is a different way this should be fixed, I am happy to pursue other avenues.