fix(l-n-b-menu-item): separate LNBMenuItem component #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samuel.park <[email protected]>
Signed-off-by: samuel.park <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yuda110
approved these changes
Aug 29, 2023
skdud4659
approved these changes
Aug 29, 2023
Comment on lines
+1
to
+17
| <script setup lang="ts"> | ||
| import { PDivider } from '@spaceone/design-system'; | ||
| </script> | ||
|
|
||
| <template> | ||
| <div class="l-n-b-divider-menu-item"> | ||
| <p-divider /> | ||
| </div> | ||
| </template> | ||
|
|
||
| <style lang="postcss" scoped> | ||
| .l-n-b-divider-menu-item { | ||
| margin-top: 1.25rem; | ||
| margin-bottom: 1.25rem; | ||
| height: 0; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Q. Is there a reason for separating components even though there's only one divider?
There was a problem hiding this comment.
There are some cases without clear usage in LNB planning, so I separated this for usage with spec.
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
) Signed-off-by: samuel.park <[email protected]>
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
) Signed-off-by: samuel.park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ciONLY)Type of Change
Affects to
Packages
Apps
Checklist
lintandtype?mirinaeshould be reflected instorybook.Description
SSIA