feat: move save button from header to filter section & refactor it #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yuda110
changed the title
yuda110
commented
Aug 29, 2023
Comment on lines
+131
to
+155
| <template v-if="costAnalysisPageState.selectedQueryId"> | ||
| <p-button v-if="costAnalysisPageState.selectedQueryId" | ||
| class="save-button" | ||
| style-type="tertiary" | ||
| icon-left="ic_disk-filled" | ||
| @click="handleSaveQuerySet" | ||
| > | ||
| {{ $t('BILLING.COST_MANAGEMENT.COST_ANALYSIS.SAVE') }} | ||
| </p-button> | ||
| <p-icon-button ref="targetRef" | ||
| class="more-menu-button" | ||
| :name="visibleContextMenu ? 'ic_chevron-up' : 'ic_chevron-down'" | ||
| style-type="tertiary" | ||
| shape="square" | ||
| size="md" | ||
| color="inherit" | ||
| @click="handleClickMoreMenuButton" | ||
| /> | ||
| <p-context-menu v-show="visibleContextMenu" | ||
| ref="contextMenuRef" | ||
| :menu="state.saveDropdownMenuItems" | ||
| :style="contextMenuStyle" | ||
| @select="handleClickSaveAsButton" | ||
| /> | ||
| </template> |
yuda110
commented
Aug 29, 2023
Comment on lines
+157
to
+162
| <p-button style-type="tertiary" | ||
| icon-left="ic_disk-edit-filled" | ||
| @click="handleClickSaveAsButton" | ||
| > | ||
| {{ $t('BILLING.COST_MANAGEMENT.COST_ANALYSIS.SAVE_AS') }} | ||
| </p-button> |
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
sulmoJ
approved these changes
Aug 29, 2023
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
…loudforet-io#1698) * feat: move save button from header to filter section Signed-off-by: yuda <[email protected]> * feat: edit validation and delete unused props Signed-off-by: yuda <[email protected]> * chore: delete unused module Signed-off-by: yuda <[email protected]> * chore: delete unused type Signed-off-by: yuda <[email protected]> * feat: edit params of `editQuery` action Signed-off-by: yuda <[email protected]> * fix: fix edit queryset bug in cost analysis Signed-off-by: yuda <[email protected]> * chore: update languages Signed-off-by: yuda <[email protected]> --------- Signed-off-by: yuda <[email protected]>
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
…loudforet-io#1698) * feat: move save button from header to filter section Signed-off-by: yuda <[email protected]> * feat: edit validation and delete unused props Signed-off-by: yuda <[email protected]> * chore: delete unused module Signed-off-by: yuda <[email protected]> * chore: delete unused type Signed-off-by: yuda <[email protected]> * feat: edit params of `editQuery` action Signed-off-by: yuda <[email protected]> * fix: fix edit queryset bug in cost analysis Signed-off-by: yuda <[email protected]> * chore: update languages Signed-off-by: yuda <[email protected]> --------- Signed-off-by: yuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ciONLY)Type of Change
Affects to
Packages
Apps
Checklist
lintandtype?mirinaeshould be reflected instorybook.Description
i) default query
ii) non-default query
