Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l-n-b): add new LNB dropdown spec & LNB minor refactoring #1699

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat(l-n-b): add new LNB dropdown spec & LNB minor refactoring #1699

merged 1 commit into from
Aug 29, 2023

Conversation

piggggggggy
Copy link
Member

To Reviewers

  • Skip (style, chore, ci ONLY)
  • Not that difficult

Type of Change

  • New feature
  • Bug fixes
  • Feature improvement
  • Refactor
  • Others (performance improvement, CI/CD, etc.)

Affects to

  • Packages

    • core-lib
    • mirinae
    • etc

  • Apps

    • storybook
    • web

Checklist

  • Did you check the lint and type?
  • Did you document the changes?
    • Changes in mirinae should be reflected in storybook.
  • Did you test the app after the package changes?

Description

SSIA

  • Add new LNB menu spec (Dropdown)
    image

@vercel
Copy link

vercel bot commented Aug 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 6:44am

yuda110
yuda110 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@yuda110 yuda110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

WANZARGEN
WANZARGEN approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So clear! I love this PR 💓

@piggggggggy piggggggggy merged commit 39f0860 into cloudforet-io:feature-cost-analysis-enhancement Aug 29, 2023
@piggggggggy piggggggggy deleted the feature-cost-analysis-enhancement branch August 29, 2023 06:52
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
@piggggggggy @sulmoJ
feat(l-n-b): add new LNB dropdown spec & LNB minor refactoring (cloud…
fb7c699 
…foret-io#1699)

Signed-off-by: samuel.park <[email protected]>
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
@piggggggggy @sulmoJ
feat(l-n-b): add new LNB dropdown spec & LNB minor refactoring (cloud…
69e9cbc 
…foret-io#1699)

Signed-off-by: samuel.park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WANZARGEN WANZARGEN WANZARGEN approved these changes

@yuda110 yuda110 yuda110 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piggggggggy @yuda110 @WANZARGEN