Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(budget-toolbox): refactor to script setup & fix allPage prop sync bug #1700

Conversation

sulmoJ
Copy link
Member

@sulmoJ sulmoJ commented Aug 29, 2023

To Reviewers

  • Skip (style, chore, ci ONLY)
  • Not that difficult

Type of Change

  • New feature
  • Bug fixes
  • Feature improvement
  • Refactor
  • Others (performance improvement, CI/CD, etc.)

Affects to

  • Packages

    • core-lib
    • mirinae
    • etc
  • Apps

    • storybook
    • web

Checklist

  • Did you check the lint and type?
  • Did you document the changes?
    • Changes in mirinae should be reflected in storybook.
  • Did you test the app after the package changes?

Description

SSIA

Things to Talk About

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 8:08am

Copy link
Member

@yuda110 yuda110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@sulmoJ sulmoJ changed the title refactor(budget-toolbox): refactor to script setup refactor(budget-toolbox): refactor to script setup & fix allPage prop sync bug Aug 29, 2023
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple! LGTM~

@sulmoJ sulmoJ merged commit 9bc69ce into cloudforet-io:feature-cost-analysis-enhancement Aug 29, 2023
@sulmoJ sulmoJ deleted the feature-cost-analysis-enhancement branch August 29, 2023 08:16
sulmoJ added a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
… sync bug (cloudforet-io#1700)

* refactor(budget-toolbox): refactor to script setup

Signed-off-by: sulmo <[email protected]>

* fix(budget-toolbox): fix allPage sync bug

Signed-off-by: sulmo <[email protected]>

---------

Signed-off-by: sulmo <[email protected]>
sulmoJ added a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
… sync bug (cloudforet-io#1700)

* refactor(budget-toolbox): refactor to script setup

Signed-off-by: sulmo <[email protected]>

* fix(budget-toolbox): fix allPage sync bug

Signed-off-by: sulmo <[email protected]>

---------

Signed-off-by: sulmo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants