Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-lib): add apiList to SpaceConnector.mockInfo #1701

Conversation

WANZARGEN
Copy link
Member

To Reviewers

  • Skip (style, chore, ci ONLY)
  • Not that difficult

Type of Change

  • New feature
  • Bug fixes
  • Feature improvement
  • Refactor
  • Others (performance improvement, CI/CD, etc.)

Affects to

  • Packages

    • core-lib
    • mirinae
    • etc
  • Apps

    • storybook
    • web

Checklist

  • Did you check the lint and type?
  • Did you document the changes?
    • Changes in mirinae should be reflected in storybook.
  • Did you test the app after the package changes?

Description

  • Added apiList to SpaceConnector.mockInfo to enable mock mode specific apis.
  • Added additional comment for description and Updated README.md

Things to Talk About

I also updated notion document.

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console 🔄 Building (Inspect) Visit Preview Aug 29, 2023 8:11am

Copy link
Member

@yuda110 yuda110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! LGTM

Copy link
Member

@piggggggggy piggggggggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! Is there going to be any sharing time?

@WANZARGEN
Copy link
Member Author

LGTM~! Is there going to be any sharing time?

Of course! I'll be sure to share it during our scheduled time tomorrow.

@WANZARGEN WANZARGEN merged commit ce89023 into cloudforet-io:feature-cost-analysis-enhancement Aug 29, 2023
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants