Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete primary_group_by & change primaryGroupBy to chartGroupBy #1705

Merged
merged 3 commits into from
Aug 30, 2023
Merged

feat: delete primary_group_by & change primaryGroupBy to chartGroupBy #1705

merged 3 commits into from
Aug 30, 2023

Conversation

yuda110
Copy link
Member

@yuda110 yuda110 commented Aug 29, 2023

To Reviewers

  • Skip (style, chore, ci ONLY)
  • Not that difficult

Type of Change

  • New feature
  • Bug fixes
  • Feature improvement
  • Refactor
  • Others (performance improvement, CI/CD, etc.)

Affects to

  • Packages

    • core-lib
    • mirinae
    • etc

  • Apps

    • storybook
    • web

Checklist

  • Did you check the lint and type?
  • Did you document the changes?
    • Changes in mirinae should be reflected in storybook.
  • Did you test the app after the package changes?

Description

SSIA

@vercel
Copy link

vercel bot commented Aug 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 1:11am

WANZARGEN
WANZARGEN approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@WANZARGEN WANZARGEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefix in the PR title doesn't seem to be clear. Also, there are failing tests, so please take a moment to review them. I'm optimistic that these issues will be resolved, and I'll proceed with approval.

@yuda110
chore: fix test
0ea23c8 
Signed-off-by: yuda <[email protected]>
skdud4659
skdud4659 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@skdud4659 skdud4659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuda110 yuda110 merged commit c7e205c into cloudforet-io:feature-cost-analysis-enhancement Aug 30, 2023
@yuda110 yuda110 deleted the feature/primary-group-by branch August 30, 2023 05:49
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
@yuda110 @sulmoJ
feat: delete primary_group_by & change primaryGroupBy to `chartGr…
74bc45c 
…oupBy` (cloudforet-io#1705)

* feat: delete `primary_group_by` & change `primaryGroupBy` to `chartGroupBy`

Signed-off-by: yuda <[email protected]>

* chore: delete unused type `stack`

Signed-off-by: yuda <[email protected]>

* chore: fix test

Signed-off-by: yuda <[email protected]>

---------

Signed-off-by: yuda <[email protected]>
sulmoJ pushed a commit to sulmoJ/console that referenced this pull request Oct 4, 2023
@yuda110 @sulmoJ
feat: delete primary_group_by & change primaryGroupBy to `chartGr…
fb89cf8 
…oupBy` (cloudforet-io#1705)

* feat: delete `primary_group_by` & change `primaryGroupBy` to `chartGroupBy`

Signed-off-by: yuda <[email protected]>

* chore: delete unused type `stack`

Signed-off-by: yuda <[email protected]>

* chore: fix test

Signed-off-by: yuda <[email protected]>

---------

Signed-off-by: yuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skdud4659 skdud4659 skdud4659 approved these changes

@WANZARGEN WANZARGEN WANZARGEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuda110 @WANZARGEN @skdud4659