refactor: change to use 'cost' not 'usd_cost' for the data property from cost api #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wanjin Noh <[email protected]>
Signed-off-by: Wanjin Noh <[email protected]>
…get-main Signed-off-by: Wanjin Noh <[email protected]>
Signed-off-by: Wanjin Noh <[email protected]>
Signed-off-by: Wanjin Noh <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yuda110
reviewed
Aug 30, 2023
| notification_type: BudgetNotificationsType; | ||
| } | ||
|
|
||
| export interface BudgetModel { |
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
…rom cost api (cloudforet-io#1706) * refactor(cost): change cost chart and helpers from usd_cost to cost Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): separate models from type.ts Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): separate shared modules into shared dir, rename budget-main Signed-off-by: Wanjin Noh <[email protected]> * fix: fix type name Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): change to use cost not usd_cost Signed-off-by: Wanjin Noh <[email protected]> --------- Signed-off-by: Wanjin Noh <[email protected]>
sulmoJ
pushed a commit
to sulmoJ/console
that referenced
this pull request
Oct 4, 2023
…rom cost api (cloudforet-io#1706) * refactor(cost): change cost chart and helpers from usd_cost to cost Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): separate models from type.ts Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): separate shared modules into shared dir, rename budget-main Signed-off-by: Wanjin Noh <[email protected]> * fix: fix type name Signed-off-by: Wanjin Noh <[email protected]> * refactor(budget): change to use cost not usd_cost Signed-off-by: Wanjin Noh <[email protected]> --------- Signed-off-by: Wanjin Noh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ciONLY)Type of Change
Affects to
Packages
Apps
Checklist
lintandtype?mirinaeshould be reflected instorybook.Description
Please review in order by commits.
BudgetPagetoBudgetMainPage.shared/directory.model.tsfile.Things to Talk About