feat: add 'Color-Coded Heatmap' widget #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
piggggggggy
approved these changes
Sep 2, 2024
| state.proxyValue = { | ||
| ...state.proxyValue, | ||
| value: state.proxyValue?.value ?? [], | ||
| baseColor: state.proxyValue?.baseColor ?? props.widgetFieldSchema?.options?.baseColor ?? DEFAULT_BASE_COLOR, |
There was a problem hiding this comment.
I think.. baseColor: props.value?.baseColor... is better than baseColor: state.proxyValue?.baseColor....
Maybe not working.
Signed-off-by: yuda <[email protected]>
Signed-off-by: yuda <[email protected]>
yuda110
merged commit 0f3fe6c
into
cloudforet-io:feature-dashboard-september
2 checks passed
yuda110
added a commit
to yuda110/cloudforet-console
that referenced
this pull request
Sep 3, 2024
* feat: add `Color-Coded Heatmap` widget Signed-off-by: yuda <[email protected]> * feat: add to widget config list Signed-off-by: yuda <[email protected]> * fix(advanced-format-rules): set init value when mounted Signed-off-by: yuda <[email protected]> * chore: update language Signed-off-by: yuda <[email protected]> * chore: delete unused variable Signed-off-by: yuda <[email protected]> * chore: add icon Signed-off-by: yuda <[email protected]> * chore: apply code review Signed-off-by: yuda <[email protected]> --------- Signed-off-by: yuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci, minor refactoring, etc.)Description