Refactor/pcollapsiblepanel logic #5553
Open
+490
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
…lapsiblePanel Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
…' into refactor/pcollapsiblepanel-logic Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
…ollapsiblepanel-logic Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
Signed-off-by: daeyeon ko <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Signed-off-by: daeyeon ko <[email protected]>
github-actions
bot
added
the
pending/review
Signed-off-by: daeyeon ko <[email protected]>
github-actions
bot
removed
the
pending/review
Signed-off-by: daeyeon ko <[email protected]>
github-actions
bot
added
the
pending/review
Signed-off-by: daeyeon ko <[email protected]>
github-actions
bot
removed
the
pending/review
WANZARGEN
approved these changes
Jan 20, 2025
packages/mirinae/src/data-display/collapsible/collapsible-panel/PCollapsiblePanel.vue
Show resolved
Hide resolved
Comment on lines
+30
to
+34
| // eslint-disable-next-line no-restricted-globals | ||
| if (isNaN(lineHeight)) { | ||
| const fontSize = parseFloat(computedStyle.fontSize); | ||
| lineHeight = fontSize * 1.2; | ||
| } |
There was a problem hiding this comment.
nitpick: Consider using Number.isNaN instead of isNaN for better type safety and to avoid implicit type coercion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewers
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)