-
Notifications
You must be signed in to change notification settings - Fork 40
feat: merge branch 'develop' into feature-query-integration #6133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
piggggggggy
merged 26 commits into
cloudforet-io:feature-query-integration
from
seungyeoneeee:feature-query-integration
Aug 18, 2025
Merged
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4577423
feat(user-page): add user-MFA bulk setting modals (#6033)
piggggggggy 9607cbf
feat(mfa-disable): create New `modal-controller` func component & sep…
piggggggggy 4736aa5
chore: separate and apply mfa-setting form components (#6039)
piggggggggy 605c018
fix: fix api endpoint blocking by version
skdud4659 3a4ab99
chore: removed unnecessary code
skdud4659 0a34a33
fix: fix api endpoint blocking by version (#6042)
skdud4659 ead3a11
chore: version 2.0.dev378
admin-cloudforet dba9a0f
chore: merge master into develop after 2.0.dev378 version tagging
admin-cloudforet abc338b
feat(mfa): apply changed user-mfa flow and refactor mfa component (#6…
piggggggggy cb76f01
feat(mfa-enforced): create mfa-enforced scenario (after sign-in) (#6047)
piggggggggy fba4f65
refactor(user-page): refactor mfa-related models (user-page) (#6048)
piggggggggy 0a519ed
chore: solve empty case
piggggggggy 41cfc70
chore: MFA QA (#6058)
piggggggggy b94e7f6
chore: add missing scenario
piggggggggy 537f93b
fix: fix tag column bug in user page (#6061)
yuda110 a8bc088
fix(action): update file path in storybook-deploy action (#6077)
sulmoJ 7e142e6
chore: mfa minor QAs (#6085)
piggggggggy 1390345
feat: apply password validation at user add/update form (#6114)
skdud4659 b3676e5
Merge branch 'develop' into feature-mfa-enhancement
piggggggggy 3322d8f
feat(mfa): implementation new mfa feature
piggggggggy 6a0a6e0
Merge branch 'develop' into feature-query-integration
seungyeoneeee f68961a
refactor: fix MFA related codes as vue query updated
seungyeoneeee 8e60970
fix: bugs about MFA updated at mypage and admin user page
seungyeoneeee 733cb1d
fix: major bug of not active of bulk MFA setting
seungyeoneeee 067be56
fix: bug of selected local users getting info from false store
seungyeoneeee b20412e
chore: fix lint error (not exist on. type)
seungyeoneeee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
apps/web/src/api-clients/identity/user-profile/schema/api-verbs/disable-mfa.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable @typescript-eslint/no-empty-interface */ | ||
export interface UserProfileDisableMfaParameters { | ||
// No parameters | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import type { MULTI_FACTOR_AUTH_TYPE } from '@/api-clients/identity/user-profile/schema/constant'; | ||
import type { MFA_STATE, MULTI_FACTOR_AUTH_TYPE } from '@/api-clients/identity/user-profile/schema/constant'; | ||
|
||
export type MultiFactorAuthType = typeof MULTI_FACTOR_AUTH_TYPE[keyof typeof MULTI_FACTOR_AUTH_TYPE]; | ||
export type MfaState = typeof MFA_STATE[keyof typeof MFA_STATE]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<script setup lang="ts"> | ||
import OTPQRInfo from '@/common/components/mfa/components/OTPQRInfo.vue'; | ||
import VerificationCodeForm from '@/common/components/mfa/components/VerificationCodeForm.vue'; | ||
import { useProxyValue } from '@/common/composables/proxy-state'; | ||
|
||
interface Props { | ||
verificationCode: string; | ||
verificationCodeInvalid: boolean; | ||
invalidText: string; | ||
} | ||
|
||
interface Emits { | ||
(e: 'update:verification-code', value: string): void; | ||
(e: 'update:verification-code-invalid', value: boolean): void; | ||
} | ||
|
||
const props = withDefaults(defineProps<Props>(), { | ||
verificationCode: '', | ||
verificationCodeInvalid: false, | ||
invalidText: '', | ||
}); | ||
|
||
const emit = defineEmits<Emits>(); | ||
|
||
/* State */ | ||
const verificationCode = useProxyValue<string>('verificationCode', props, emit); | ||
const verificationCodeInvalid = useProxyValue<boolean>('verificationCodeInvalid', props, emit); | ||
|
||
|
||
</script> | ||
|
||
<template> | ||
<div class="o-t-p-form"> | ||
<o-t-p-q-r-info /> | ||
<verification-code-form :invalid.sync="verificationCodeInvalid" | ||
:code-value.sync="verificationCode" | ||
:invalid-text="props.invalidText" | ||
/> | ||
</div> | ||
</template> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number for cooldown time should be extracted to a configuration file or constant. Consider making this configurable based on security requirements.
Copilot uses AI. Check for mistakes.