Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all of the codes for maintenance #386

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Refactor all of the codes for maintenance #386

merged 13 commits into from
Oct 4, 2024

Conversation

yjinjo
Copy link
Contributor

@yjinjo yjinjo commented Oct 4, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Refactor all of the codes for maintenance

@yjinjo
refactor: modify code such that workspace_group's workspace_count
e2597e7 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: add exclude_unset option when create workspace group
55a6592 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: remove workspace_count of workspace_group_manager
e87501c 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor add exclude_unset option when update workspace group
7cfbeef 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor when delete workspace_group, which has users or workspace
693bb3f 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
chore: rename method
7c5c9f3 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
Merge branch 'master' of https://github.com/cloudforet-io/identity
08b51f7
@yjinjo
refactor: add_users for both workspace_group and workspace_group_user
238ba14 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
chore: add params type
857890a 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: remove_users for workspace_group and workspace_group_user
de457b3 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: remove unnessesary methods for add_users
f7005b5 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: add type for remove_users
14e2e9c 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo
refactor: update_role for workspace_group and workspace_group_user
cc4a9de 
Signed-off-by: Youngjin Jo <[email protected]>
@yjinjo yjinjo added the enhancement New feature or request label Oct 4, 2024
@yjinjo yjinjo requested a review from ImMin5 October 4, 2024 09:40
@yjinjo yjinjo self-assigned this Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

⚠️ @yjinjo the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@yjinjo yjinjo merged commit b787155 into cloudforet-io:master Oct 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImMin5 ImMin5 Awaiting requested review from ImMin5

Assignees

@yjinjo yjinjo

Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yjinjo