Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission error when deleting user_secret in user_service disable_mfa method #401

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lhhyung
Copy link
Member

@lhhyung lhhyung commented Oct 25, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Fix permission error when deleting user_secret in user_service disable_mfa method

Known issue

Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 1 commits:

  • f9f83f8: fix: Fix permission error when deleting user_secret in user_service disable_mfa method

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@lhhyung lhhyung requested a review from ImMin5 October 25, 2024 06:09
@lhhyung lhhyung self-assigned this Oct 25, 2024
@lhhyung lhhyung added the enhancement New feature or request label Oct 25, 2024
Copy link
Member

@ImMin5 ImMin5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ImMin5 ImMin5 merged commit 00a5efc into cloudforet-io:master Oct 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants