This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Add the ability to include extra routes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you want to add arbitrary routes? |
|
Currently, the gorouter adds a /routes on to the component. |
|
A different way would be to generalize the whole thing and provide a default set which are for /varz and /healthz. |
Pass the ip address to the VarzMessage Fix the testcases: Stop the server Close the body when reading responses Use different ports (safest solution to prevent other issues)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the testcases:
Stop the server
Close the body when reading responses
Use different ports (safest solution to prevent other issues)